On Mon, 15 Jun 2026 16:44:33 GMT, Valerie Peng <[email protected]> wrote:
>> Brent Christian has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add new test to test lists > > src/java.smartcardio/share/classes/sun/security/smartcardio/CardImpl.java > line 128: > >> 126: >> 127: this.context = new Context(localCardId, State.OK); >> 128: this.cleanable = CleanerFactory.cleaner().register(this, >> this.context); > > Move these two lines to be right after the SCardConnect(...) call? Otherwise, > the cleaner may be skipped if some error occurred in between. That's a good point, there are several places where something like an OOME might get thrown. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30683#discussion_r3417009317
