On Fri, 1 May 2026 18:53:11 GMT, Sean Mullan <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> additional data cleanup.
>
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 385:
>
>> 383:
>> 384: /**
>> 385: * {@return the password bytes}
>
> Should say returns a new copy/clone each time it is called.
>
> Need to add an `@throws IllegalStateException`.
Yes.
> src/java.base/share/classes/javax/crypto/spec/Argon2ParameterSpec.java line
> 395:
>
>> 393:
>> 394: /**
>> 395: * {@return the salt}
>
> Should say returns a new copy/clone each time it is called.
Yes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3503422546
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3503424363
