On Thu, 6 Aug 2026 21:35:48 GMT, Valerie Peng <[email protected]> wrote:

>> Initial commit containing the public API changes and related regression 
>> tests.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Valerie Peng has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   import cleanup.

src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 222:

> 220:                             });
> 221:                         }
> 222:                         latch.await();

If `latch.await()` is interrupted, control jumps past both shutdown() calls. 
Wouldn't it be better to add a `finally` clause (after `catch 
(InterruptedException ie)`) and move shutdown() calls there?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3779781900

Reply via email to