On Sat, 25 Jul 2026 10:47:30 GMT, Mikhail Yankelevich
<[email protected]> wrote:
>> Sean Mullan has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Support lines of just whitespace.
>> - Support all delimiters ('=', ':', whitespace)
>> - Use ISO_8859_1 to read/write property files.
>> Improve SkippedException message.
>
> test/jdk/tools/jlink/plugins/SecurityPropertiesPluginTest.java line 61:
>
>> 59: helper = Helper.newHelper(LINKABLE_RUNTIME);
>> 60: if (helper == null) {
>> 61: throw new SkippedException("Test not run");
>
> nit, I think it might be more descriptive in case this is triggered:
>
> Suggestion:
>
> throw new SkippedException("No Linkable Runtime");
Fixed in
https://github.com/openjdk/jdk/pull/31884/changes/3d7abfc4b07bdd1007b99a47c147166fd1e00d18
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31884#discussion_r3847213588
