On Mon, 14 Sep 2026 18:05:03 GMT, Weijun Wang <[email protected]> wrote:
>> Add ML-DSA and ML-KEM default parameter sets for `keytool -genkeypair`. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > more man page changes src/java.base/share/classes/sun/security/tools/keytool/Main.java line 1935: > 1933: keysize = > SecurityProviderConstants.DEF_DSA_KEY_SIZE; > 1934: } else if ("EdDSA".equalsIgnoreCase(keyAlgName)) { > 1935: keysize = SecurityProviderConstants.DEF_ED_KEY_SIZE; Can we also remove the constants not used here like `DEF_ED_KEY_SIZE` now? For example, it looks like we can initialize with the Ed25519 `NamedParameterSpec` [here](https://github.com/openjdk/jdk/blob/d9397cebdb4945dbf10f9d9751fee72781dd89cf/src/java.base/share/classes/sun/security/ec/ed/EdDSAKeyPairGenerator.java#L54) instead of the key size. That is the only other place it is used. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32616#discussion_r4018809502
