On Tue, 13 Oct 2026 07:57:18 GMT, Alan Bateman <[email protected]> wrote:
>> Sean Mullan has updated the pull request incrementally with eight additional
>> commits since the last revision:
>>
>> - Remove whitespace, fix continuation char.
>> - Test property with EOF immediately after continuation character
>> - Disallow include statement in java.security file.
>> - Check for duplicates in java.security file.
>> - Remove redundant prop.
>> - Remove extra back-tick.
>> - Test more properties with different escape characters.
>> - Store properties as specified by Properties.store(OutputStream, String).
>
> test/jdk/tools/jlink/plugins/SecurityPropertiesPluginTest.java line 189:
>
>> 187: Path jdkJmodsPath = Path.of(System.getProperty("test.jdk"),
>> "jmods");
>> 188: Path jdkJmodsCopyPath = Path.of(TEST_DIR, "jmodsCopy");
>> 189: FileUtils.copyDirectory(jdkJmodsPath, jdkJmodsCopyPath);
>
> I assume this will fail if configured with `--enable-linkable-runtime`. Look
> at the existing jlink tests to see examples how they work or skip with these
> builds.
I believe the test already does this. See lines 150-152:
helper = Helper.newHelper(LINKABLE_RUNTIME);
if (helper == null) {
throw new SkippedException("Test not run: no linkable runtime");
}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31884#discussion_r4261851350
