On Tue, 20 Oct 2026 22:59:42 GMT, Valerie Peng <[email protected]> wrote:

>> Initial commit containing the public API changes and related regression 
>> tests.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Valerie Peng has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Updated to address Weijun's review comments.

src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 411:

> 409:                 bl.doFinal(v, 0);
> 410: 
> 411:                 int r = ((outLen + 31) >> 5) - 2;

I suggest to use `Math.ceilDiv(outLen, 32) - 2` instead to avoid integer 
overflow.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4405754966

Reply via email to