On Wed, 7 Oct 2026 17:59:42 GMT, Kieran Farrell <[email protected]> wrote:

>> This patch adds a new jcmd diagnostic command, `VM.show_settings`, to make 
>> the existing -`XshowSettings` output available from a running VM. The 
>> command accepts the same sections as`XshowSettings` (all, vm, properties, 
>> locale, security, system, security:all, security:properties, 
>> security:providers, security:tls). 
>> 
>> HotSpot registers the new diagnostic command, validates the requested 
>> section, then calls into `sun.launcher.LauncherHelper` to reuse the existing 
>> show settings formatting and return the result as bytes for the jcmd stream. 
>> The VM settings path also passes hotspots `InitialHeapSize`, `MaxHeapSize`, 
>> and Java thread stack size into the Java helper. A new jcmd test covers VM, 
>> properties, security TLS, and invalid-input output.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Kieran Farrell has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   alternate output for Security provider selection based on invocation

src/java.base/share/classes/jdk/internal/launcher/SecuritySettings.java line 
168:

> 166:         ostream.println(INDENT + (fromLauncher
> 167:                 ? "Security provider static configuration: (in order of 
> preference)"
> 168:                 : "Currently registered security providers (in order of 
> preference):"));

Looks good - minor nit - let's be consistent with placement of ':'

I think the line 168 format is better. 
e.g.
"Security provider static configuration (in order of preference):"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31742#discussion_r4465611058

Reply via email to