On 12/06/2016 12:24 PM, [email protected] wrote: > From: Yongqin Liu <[email protected]> > > Here is just the quick fix for tracefs with selinux. > just add tracefs to the list of whitelisted filesystem > types in selinux_is_sblabel_mnt(), but the right fix would be to > generalize this logic as described in the last item on the todo list, > https://bitbucket.org/seandroid/wiki/wiki/ToDo > > Change-Id: I2aa803ccffbcd2802a7287514da7648e6b364157
Please rewrite the subject line and patch description per the kernel's submission guidelines, drop the Change-Id and the link to the SEAndroid todo list, and don't say that this is a quick fix but the right fix is something else if you want this to actually be merged. Because in that case, you ought to just implement the right fix. There is now an upstream kernel issue for the right fix: https://github.com/SELinuxProject/selinux-kernel/issues/2 > Signed-off-by: Yongqin Liu <[email protected]> > --- > security/selinux/hooks.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index 09fd610..24bd84d 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -491,6 +491,7 @@ static int selinux_is_sblabel_mnt(struct super_block *sb) > !strcmp(sb->s_type->name, "sysfs") || > !strcmp(sb->s_type->name, "pstore") || > !strcmp(sb->s_type->name, "debugfs") || > + !strcmp(sb->s_type->name, "tracefs") || > !strcmp(sb->s_type->name, "rootfs"); > } > > _______________________________________________ Selinux mailing list [email protected] To unsubscribe, send email to [email protected]. To get help, send an email containing "help" to [email protected].
