[resending as plain text only - sorry] Ping? Any feedback on this patch?
LGTM. cheers, grant On Thu, Mar 16, 2017 at 3:26 PM, Matthias Kaehlcke <m...@chromium.org> wrote: > 'perms' will never be NULL since it isn't a plain pointer but an array > of u32 values. > > This fixes the following warning when building with clang: > > security/selinux/ss/services.c:158:16: error: address of array > 'p_in->perms' will always evaluate to 'true' > [-Werror,-Wpointer-bool-conversion] > while (p_in->perms && p_in->perms[k]) { > > Signed-off-by: Matthias Kaehlcke <m...@chromium.org> > --- > security/selinux/ss/services.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c > index 082b20c78363..2f20b5f974f4 100644 > --- a/security/selinux/ss/services.c > +++ b/security/selinux/ss/services.c > @@ -155,7 +155,7 @@ static int selinux_set_mapping(struct policydb *pol, > } > > k = 0; > - while (p_in->perms && p_in->perms[k]) { > + while (p_in->perms[k]) { > /* An empty permission string skips ahead */ > if (!*p_in->perms[k]) { > k++; > -- > 2.12.0.367.g23dc2f6d3c-goog > _______________________________________________ Selinux mailing list Selinux@tycho.nsa.gov To unsubscribe, send email to selinux-le...@tycho.nsa.gov. To get help, send an email containing "help" to selinux-requ...@tycho.nsa.gov.