On Sat, Apr 1, 2017 at 2:40 AM, SF Markus Elfring <[email protected]> wrote: >>>> We removed this initialization as a cleanup but it is probably >>>> required. >>>> >>>> The concern is that "nel" can be zero. I'm not an expert on SELinux >>>> code but I think it looks possible to write an SELinux policy which >>>> triggers this bug. GCC doesn't catch this, but my static checker >>>> does. >>>> >>>> Fixes: 9c312e79d6af ("selinux: Delete an unnecessary variable >>>> initialisation in range_read()") >>>> Signed-off-by: Dan Carpenter <[email protected]> >>> >>> Nice catch, thanks! >>> >>> Acked-by: Stephen Smalley <[email protected]> >> >> Yes, indeed. Thanks Dan, I should have caught this when merging Markus' >> patch. > > How do you think about the possibility to call the function “range_read” only > with > a system configuration where the interface “le32_to_cpu” will be resolved to > a positive value so that statements in the corresponding for loop will be > executed > at least once?
I suggest we leave this as-is for the moment. -- paul moore www.paul-moore.com _______________________________________________ Selinux mailing list [email protected] To unsubscribe, send email to [email protected]. To get help, send an email containing "help" to [email protected].
