Title: Untitled Document
Hi,

I think the newline is necessary.
Without the newline the headers seems like this:

Contact: <sip:[email protected]:5060>
Refer-To: sip:[email protected]:5060Max-Forwards: 70
Content-Length: 0

So, yes it is a bug currently.



I extended the IVR plugin for sending BYE with headers.

Index: IvrDialogBase.cpp
===================================================================
--- IvrDialogBase.cpp    (revision 1354)
+++ IvrDialogBase.cpp    (working copy)
@@ -182,12 +182,18 @@
   return Py_None;
 }
 
-static PyObject* IvrDialogBase_bye(IvrDialogBase* self, PyObject*)
+static PyObject* IvrDialogBase_bye(IvrDialogBase* self, PyObject* args)
 {
+  char* hdrs=0;
+
   assert(self->p_dlg);
-  self->p_dlg->dlg.bye();
+  if(!PyArg_ParseTuple(args,"s", &hdrs))
+    return NULL;
+
+  self->p_dlg->dlg.bye(hdrs);
   Py_INCREF(Py_None);
   return Py_None;

 }
 
 //





Stefan Sayer wrote:
Hello,

how about the trailing newline? your patch adds a \n in both cases. Is that a bug currently?

Thanks
Stefan



--
  Balint Kovacs
Software Engineer
Gamma Telecom
Mobile +36 (06) 70 244 6677
Phone +44 (0) 207 078 8213
Email [email protected]
Web www.gammatelecom.com
_______________________________________________
Semsdev mailing list
[email protected]
http://lists.iptel.org/mailman/listinfo/semsdev

Reply via email to