Re: [Semsdev] playing precoded gsm/ilbc files

[Самусенко Андрей]

Hi, Stefan. I want to remind you about my offer. Is it useful? Coding audio data on a fly is difficult, I think transfering of static data is much better. Please, answer, are you going to add this functionality otherwise we will have to fork from current version. On 18.12.2009 05:24, Stefan Sayer wrote: Hi Andrey, that makes sense. I will try it and apply it. Thanks! Stefan o Самусенко Андрей [12/16/2009 01:22 PM]: Hi Stefan. I want to offer two functions for working with precoded files: void AmPrecodedFile::initPlugin() and AmAudioRtpFormat* AmSession::getNewRtpFormat() initPlugin() is required because payloads from .def files must be available at AmAudio.cpp:78. RTP format can be changed as soon as call is placed on hold. In this case AmSession::acceptAudio() calls AmRtpAudio::init(), which doesn't consider AmPrecodedRtpFormat. Thats why we need a virtual getNewRtpFormat() in AmSession. Code in attach. On 05.12.2009 05:18, Stefan Sayer wrote: Hi Andrey, sorry, I am a little lost here and need a little while until i understand this. Does that mean that with your patch it works now? Thanks a lot Stefan o Самусенко Андрей [12/03/2009 11:12 AM]: precoded_payload_t* p = static_cast<precoded_payload_t*>(AmPlugIn::instance()->payload(h_codec)); have same behaviour: segfault. precoded_bytes2samples() called on dead AmPrecodedRtpFormat. Самусенко Андрей wrote: Fixed. Please, examine following code: ............. Самусенко Андрей wrote: Bug found, but no know solution. On REFER h_codec == 0 after session terminated, but RTP(silence by SJphone or other) continue and SEMS segfault. Самусенко Андрей wrote: 18;G729;8000;1;<none>;10;10;test8k.g729       and 18;G729;8000;1;<none>;20;20;test8k.g729       works. Please, just comment "hack". h_codec = (long*)this; is abnormal solution. Need graceful code, but no a full understanding. Stefan Sayer wrote: Hi, o Stefan Sayer [10/22/09 17:45]: thanks, it is applied as r1557. I tried and GSM work fine now. Does it now also work with G729? (I can't find any proper samples to test with at the moment). to answer my own question: yes it does. how nice! Stefan _______________________________________________ Semsdev mailing list Semsdev@lists.iptel.org http://lists.iptel.org/mailman/listinfo/semsdev _______________________________________________ Semsdev mailing list Semsdev@lists.iptel.org http://lists.iptel.org/mailman/listinfo/semsdev _______________________________________________ Semsdev mailing list Semsdev@lists.iptel.org http://lists.iptel.org/mailman/listinfo/semsdev

_______________________________________________
Semsdev mailing list
Semsdev@lists.iptel.org
http://lists.iptel.org/mailman/listinfo/semsdev