Hmm, also related to this R1827 change, I was wondering if we couldn't have a "previous_status" (where "status" would be saved, before changing it) as AmSipDialog member, rather then passing the old_dlg_status as function parameter to all the callbacks; then, we'd also have a getPreviousStatus() member function.
(But didn't think too much about concurrent accesses, where function parameters would be justified.) Cheers, Bogdan. On 07/02/10 10:22, Bogdan Pintea wrote: > Hi guys, > > I'm having some troubles with the callback app (AmB2ABCalleeSession, in > fact), coupled with the uac_auth module: the callee session is > terminated upon reception of the (expected) 40[17]; this answer is > correctly dealt with by the uac_auth, but due to the change in the > callback invocation, the dialog now transitions from Pending to > Disconnected; the call flow would be: > > AmSipReplyEvent->updateStatus(), where > - Pending->Discon'ed and then > - through [AmSipDialogEventHandler]->onSipReply() callbacks, the > AmB2ABCalleeSession's method generates a B2ABConnectOtherLegFailedEvent. > > Lemme know if this is still WIP, waiting for completion. > > Thanks, > Bogdan. > > On 04/26/10 18:25, [email protected] wrote: >> Author: rco >> Date: 2010-04-26 18:25:01 +0200 (Mon, 26 Apr 2010) >> New Revision: 1827 >> >> Modified: >> trunk/apps/Makefile >> trunk/apps/announce_transfer/AnnounceTransfer.cpp >> trunk/apps/announce_transfer/AnnounceTransfer.h >> trunk/apps/auth_b2b/AuthB2B.cpp >> trunk/apps/auth_b2b/AuthB2B.h >> trunk/apps/call_timer/CallTimer.cpp >> trunk/apps/conference/Conference.cpp >> trunk/apps/conference/Conference.h >> trunk/apps/registrar_client/SIPRegistrarClient.cpp >> trunk/apps/registrar_client/SIPRegistrarClient.h >> trunk/apps/sst_b2b/SSTB2B.cpp >> trunk/apps/sst_b2b/SSTB2B.h >> trunk/apps/sw_prepaid_sip/SWPrepaidSIP.cpp >> trunk/apps/webconference/WebConferenceDialog.cpp >> trunk/apps/webconference/WebConferenceDialog.h >> trunk/core/AmB2ABSession.cpp >> trunk/core/AmB2ABSession.h >> trunk/core/AmB2BSession.cpp >> trunk/core/AmB2BSession.h >> trunk/core/AmPlugIn.h >> trunk/core/AmSession.cpp >> trunk/core/AmSession.h >> trunk/core/AmSessionEventHandler.h >> trunk/core/AmSipDialog.cpp >> trunk/core/AmSipDialog.h >> Log: >> - make the AmSipDialog call the SIP event handler within AmSession, instead >> of the opposite. >> - WARNING: this code is not yet tested. > _______________________________________________ > Semsdev mailing list > [email protected] > http://lists.iptel.org/mailman/listinfo/semsdev > _______________________________________________ Semsdev mailing list [email protected] http://lists.iptel.org/mailman/listinfo/semsdev
