Man, that was a big ordeal trying to get that patch to work. Ultimately installing git and using git apply did work after working through some issues.
Good news is that it appears to pass all the tests that I have for it. I haven't gone into ensuring everything works with it but when I have time I will go through and test as many commands as I can as related to #identifier. For example, I haven't tested all the schema manipulation methods. Sunny On Nov 16, 2:37 pm, Sunny Hirai <[EMAIL PROTECTED]> wrote: > Hi Jeremy, > > I'm going to assume it was an error in the way I applied the patch. > I'll try again and report back. The funny thing is that the patch > program successfully completed without any errors. Hmm... > > I haven't installed git onto this machine yet but I may try that to do > the patch too. > > BTW, it is insane how quickly you respond to issues. > > Sunny > > On Nov 16, 11:47 am, Jeremy Evans <[EMAIL PROTECTED]> wrote: > > > On Nov 16, 11:35 am, Sunny Hirai <[EMAIL PROTECTED]> wrote: > > > > Hi Jeremy, > > > > Thanks for providing the patch as a separate file. This actually made > > > it possible for me to patch on the home computer using GNUWIN32 patch. > > > We don't use patch files at work so I'm just getting used to them. :) > > > > At any rate, I did find a bug when trying to run this: > > > > db = Sequel.connect( "mysql://root:[EMAIL PROTECTED]/test" ) > > > > db.create_table :double__underscores.identifier do > > > varchar :name > > > end > > > > db.drop_table :double__underscores.identifier > > > > So this was run against my test database. It successfully creates > > > the :double__underscores table but it doesn't successfully drop the > > > table. > > > > Here are the Sequel error messages: > > > > undefined method `remove_cached_schema' for #<Sequel::MySQL::Database: > > > "mysql://root:[EMAIL PROTECTED]/test"> - NoMethodError > > > c:/ruby/lib/ruby/gems/1.8/gems/sequel-2.7.1/lib/sequel_core/database/ > > > schema.rb, line: 112, method: drop_table » > > > c:/ruby/lib/ruby/gems/1.8/gems/sequel-2.7.1/lib/sequel_core/database/ > > > schema.rb, line: 111, method: each » > > > c:/ruby/lib/ruby/gems/1.8/gems/sequel-2.7.1/lib/sequel_core/database/ > > > schema.rb, line: 111, method: drop_table » > > > That's very strange, as remove_cached_schema should definitely be > > defined, unless the patch program screwed up. See if you have > > remove_cached_schema defined around line 260 of lib/sequel_core/schema/ > > sql.rb. It's definitely in the patch. If it's not defined, try using > > a different patch program. If it is defined, I'm not sure what to > > make of it. It works fine with PostgreSQL and SQLite, I haven't > > tested it with MySQL yet. Does git apply not work? You could try the > > patch program in UnxUtils as well. > > > Jeremy > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en -~----------~----~----~----~------~----~------~--~---
