On Jun 23, 5:31 pm, Amit Chakradeo (अमित चक्रदेव) <[email protected]> wrote: > Hi, > > I needed to_csv convenience method, but the current implementation does > not escape commas and special character. I have a patch which uses csv > library and properly escapes the data. > > http://github.com/amit/sequel/commit/bbffd519b5d466fe0b320a0bf18d86ae... > > Let me know your comments on this patch. It's working for me right now, > but I will add new spec so that it tests the escaping.
Requiring the csv library when very little code uses Dataset#to_csv is not acceptable. I recommend just using an extension that does that. If no one here objects, I don't have a problem with moving Dataset#to_csv to an extension and shipping it with with Sequel. Once it is an extension, using the csv library for it is acceptable. Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en.
