On May 4, 4:42 am, Christian MICHON <[email protected]>
wrote:
> Hi,
>
> I needed to list views of a specific database through jdbc.
>
> It was not too difficult to implement, but this is coded only in jdbc adapter.
>
> I tested it manually with jtds (mssql) and automatically using bacon
> with h2 jdbc driver.
>
> It's also available as pastiehttp://pastie.org/1863772

I don't think this is good to add to just JDBC adapters.  It's
basically a new type of metadata query that most database types should
implement (like Database#tables), so before integrating it into
Sequel, we should at least support it on PostgreSQL, MySQL, and
SQLite, and probably MSSQL and H2 as well.

I'm not opposed to adapter specific methods if the behavior is adapter
specific, but I think we should avoid adding methods to a single
adapter that make sense for most adapters.  Otherwise things start
looking inconsistent, and I'd like to avoid that.

I'll look into adding a Database#views method in other adapters, as
well as adding integration tests for it.  I'll certainly use your
patch for the JDBC adapter if I commit support for Database#views.

Jeremy

-- 
You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sequel-talk?hl=en.

Reply via email to