Hi Emmanuel,

On 1/23/07, Emmanuel Cecchet <[EMAIL PROTECTED]> wrote:
Yes, I propose to reapply the SEQUOIA-518 fix used in getTable(String)
to getTable(String, boolean).
I will commit a patch for this. Let me know if this works for you.

First of all we should probably refactor this code in a
cleanQuotedIdentifiers or trimQuotes method or something like that :).
It will prevent failures if the support of a new funky database system
with its own syntax to quote identifiers is added in the future.

IMHO, we should store in the hashmap the clean version of the table
name because we currently have two differents behaviours:
- in the case when we create the table directly in Sequoia, the schema
is updated with "tablename",
- when we stop and restart the controller, we store tablename in the
schema and not "tablename".

Storing the clean version will allow us to have a consistent behaviour
in both cases.

Another question is to know if we can afford the added clean (we
should then clean directly the table name before looking in the
hashmap) in certain cases.

--
Guillaume

_______________________________________________
Sequoia mailing list
[email protected]
https://forge.continuent.org/mailman/listinfo/sequoia

Reply via email to