On Apr 24, 2008 at 14:57, Alfred E. Heggestad <[EMAIL PROTECTED]> wrote: > Andrei Pelinescu-Onciul wrote: > >On Apr 22, 2008 at 11:03, Alfred E. Heggestad <[EMAIL PROTECTED]> wrote: > >>Hi > >> > >>I have added support CRLF ping/pong keepalives aka SIP outbound > >>style (http://tools.ietf.org/html/draft-ietf-sip-outbound-13). > >>(thanks to Andrei for guidance). > > > >Thanks a lot for the patch :-) > >> > >>The patch is against SER v2.1 and adds a new configuration item > >>in tcp_options.crlf_ping which is enabled by default. > > > >I don't see how it can be changed from ser.cfg (missing cfg.lex/.y > >patch?). > > this is now added in the attached patch, as config option "tcp_crlf_ping" > > please review the name of this param, if you prefer something else > (like tcp_keep_xyz) then I can change this..
I have nothing against it :-) > > > >> > >>the code works by looking for empty double CRLF's in between > >>SIP messages, and when detected it will respond with a single > >>CRLF on the same TCP connection. > >> > >> > >>I have done some brief testing, but this patch needs much > >>more heavy testing before it is accepted into CVS (if?) > > > >The patch looks ok to me so please commit it after you add the missing > >ser.cfg support. If somehing goes wrong one can always disable it from > >ser.cfg and you'll get your testing :-) > >Don't forget to add some entry in the NEWS file. > > > > I added an entry in the NEWS file (see attached patch). > > but I do not have commit rights for the root-dir, so I think someone > else needs to commit the patch (if approved) ... :) I've fixed that (the comit rights part), so go ahead and comit the patch. Andrei [...] _______________________________________________ Serdev mailing list [email protected] http://lists.iptel.org/mailman/listinfo/serdev
