> > > Did you see the patch I did to SMTPHandler earlier today?
> I haven't
> > > committed it, but it seems that our patches need to be merged.
>
> > Just replaced your
> > ...
> > And moved the check a few lines later.
>
> I believe that you broke the code with that last change.
> Please check me on this, since I plan to apply and then fix
> the code again.
>
> You moved the check inside the authRequired check. I want it
> OUTSIDE the check because I want for it to apply to ALL
> e-mail, regardless of whether auth is required or not.
Here is your condition:
if (blocklisted && // was found in the RBL
(authRequired && getUser() == null) && // not authenticated -- don't care
if it is local or not
!(recipientAddress.getUser().equalsIgnoreCase("postmaster") ||
recipientAddress.getUser().equalsIgnoreCase("abuse"))) {
I see that all the conditions are in "&&" and one of them is "authRequired".
I simply moved that code inside a block that already checked the
authRequired. I think I simply "refactored" your code with no change to the
behaviour.
I did not check your intended behaviour, I simply refactored it.
Am I missing something?
Stefano
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
