[
http://issues.apache.org/jira/browse/JAMES-451?page=comments#action_12372437 ]
Stefano Bagnara commented on JAMES-451:
---------------------------------------
I committed the latest patches but now a test fail.
I had to apply your patches manually because the format was not correctly
handled by Eclipse: can you check I committed all the code and why the test
doesn't pass?
testEhloResolv(), line 332:
junit.framework.AssertionFailedError: expected error: ehlo could not resolved
expected:<501> but was:<250>
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.failNotEquals(Assert.java:282)
at junit.framework.Assert.assertEquals(Assert.java:64)
at junit.framework.Assert.assertEquals(Assert.java:201)
at
org.apache.james.smtpserver.SMTPServerTest.testEhloResolv(SMTPServerTest.java:332)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at junit.framework.TestCase.runTest(TestCase.java:154)
at junit.framework.TestCase.runBare(TestCase.java:127)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:118)
at junit.framework.TestSuite.runTest(TestSuite.java:208)
at junit.framework.TestSuite.run(TestSuite.java:203)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:478)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:344)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)
> Check for valid domain in HELO
> ------------------------------
>
> Key: JAMES-451
> URL: http://issues.apache.org/jira/browse/JAMES-451
> Project: James
> Type: Wish
> Components: SMTPServer
> Reporter: Norman Maurer
> Assignee: Stefano Bagnara
> Attachments: ehlo-junit.patch, ehlo.patch, helo-v2-junit.patch,
> helo-v2.patch, helo.patch
>
> IT would be nice to let
> /james-dev/src/java/org/apache/james/smtpserver/HeloCmdHandler.java to accept
> an init parameter for specify that the helo value must be an resolvable
> domainname. In RFC HELO names should always a valid domainname.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
