Author: bago
Date: Sun Apr  9 06:20:02 2006
New Revision: 392718

URL: http://svn.apache.org/viewcvs?rev=392718&view=rev
Log:
Removed print of e.getMessage() to the SMTP reply to avoid wrong multiline 
response and to avoid giving internal informations (stacktrace) to unknown 
users (see JAMES-475)

Modified:
    james/server/trunk/src/java/org/apache/james/smtpserver/SendMailHandler.java

Modified: 
james/server/trunk/src/java/org/apache/james/smtpserver/SendMailHandler.java
URL: 
http://svn.apache.org/viewcvs/james/server/trunk/src/java/org/apache/james/smtpserver/SendMailHandler.java?rev=392718&r1=392717&r2=392718&view=diff
==============================================================================
--- 
james/server/trunk/src/java/org/apache/james/smtpserver/SendMailHandler.java 
(original)
+++ 
james/server/trunk/src/java/org/apache/james/smtpserver/SendMailHandler.java 
Sun Apr  9 06:20:02 2006
@@ -89,8 +89,7 @@
                    session.getState().put(SMTPSession.MESG_FAILED, 
Boolean.TRUE);
                    // then let the client know that the size
                    // limit has been hit.
-                   responseString = "552 
"+DSNStatus.getStatus(DSNStatus.PERMANENT,DSNStatus.SYSTEM_MSG_TOO_BIG)+" Error 
processing message: "
-                             + e.getMessage();
+                   responseString = "552 
"+DSNStatus.getStatus(DSNStatus.PERMANENT,DSNStatus.SYSTEM_MSG_TOO_BIG)+" Error 
processing message.";
                    StringBuffer errorBuffer =
                      new StringBuffer(256)
                          .append("Rejected message from ")
@@ -103,8 +102,7 @@
                          
.append(session.getConfigurationData().getMaxMessageSize());
                    getLogger().error(errorBuffer.toString());
               } else {
-                   responseString = "451 
"+DSNStatus.getStatus(DSNStatus.TRANSIENT,DSNStatus.UNDEFINED_STATUS)+" Error 
processing message: "
-                             + me.getMessage();
+                   responseString = "451 
"+DSNStatus.getStatus(DSNStatus.TRANSIENT,DSNStatus.UNDEFINED_STATUS)+" Error 
processing message.";
                    getLogger().error("Unknown error occurred while processing 
DATA.", me);
               }
               session.writeResponse(responseString);



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to