[ 
http://issues.apache.org/jira/browse/JAMES-488?page=comments#action_12378687 ] 

Noel J. Bergman commented on JAMES-488:
---------------------------------------

The patch took static methods and made them instance methods.  Not a fan of 
doing that.  You can still reference static methods from the instance without 
changing the declaration of the method.

As for the static class, it was intentionally static for the precise reason 
mentioned.  We don't want it to have special access to the enclosing object.

> Remove static access of DNSServer
> ---------------------------------
>
>          Key: JAMES-488
>          URL: http://issues.apache.org/jira/browse/JAMES-488
>      Project: James
>         Type: Improvement

>   Components: DNSServer
>     Reporter: Norman Maurer
>     Assignee: Norman Maurer
>  Attachments: DNSServer-non-static-usage2.patch, 
> DNSServer-not-static-usage.patch
>
> We should remove all static access to DNSServer and move the methods to the 
> DNSServer interface. After that we should be able to acces this via the 
> interface Serviceable. 
> This will it make easier to write junit tests etc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to