[ http://issues.apache.org/jira/browse/JAMES-486?page=comments#action_12411907 ]
Bernd Fondermann commented on JAMES-486: ---------------------------------------- Did not commit the changes myself because I could not test them and thought it was not fair to break something only for the beauty of the code ;-) I'm curious, how do you test these features? In particular, how do you set the ERROR state? Regarding your latest commit: a. You seem to have changed the behavior of the DELETESPOOL command. Before the latest commit, every mail could be deleted if you gave the key. Now, only ERROR mails can be removed. I see this is now aligned with the other commands, but why do we restrict to ERROR mails? b. I ask myself, if it is neccessary to put the .unlock() calls in finally blocks? In cases where messages are not in error state, only lock() is called, but no matching unlock(). c. should we move remove[Error]Mail() & resendErrorMail() to the SpoolRepository or some utility class? Please tell me if I'm nitpicking... ;-) > Spool managing commands for remote manager > ------------------------------------------ > > Key: JAMES-486 > URL: http://issues.apache.org/jira/browse/JAMES-486 > Project: James > Type: New Feature > Components: Remote Manager > Reporter: Norman Maurer > Assignee: Norman Maurer > Fix For: 2.4.0 > Attachments: RemoteDelivery-retry-fix.patch, RemoteManHandler.diff, > RemoteManager-SpoolManagement.patch > > Spool managing commands for remote manager - first proposal for review -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
