[ http://issues.apache.org/jira/browse/JAMES-509?page=comments#action_12413407 ]
Joachim Draeger commented on JAMES-509: --------------------------------------- I haven't had my hands in the fetchmail code so I only can do a fast review. And the patch makes sense to me. For example there are getters an setters for variables only used locally in one method. If you don't have them local you always have to check for references and side effects when reading that code. IMHO it looks a bit over-designed to me. > Cleanup/Refactor FetchMail code > ------------------------------- > > Key: JAMES-509 > URL: http://issues.apache.org/jira/browse/JAMES-509 > Project: James > Type: Improvement > Components: FetchMail > Versions: 2.4.0 > Reporter: Stefano Bagnara > Assignee: Stefano Bagnara > Fix For: 2.4.0 > Attachments: fetchmail-refactoring1 > > Current FetchMail code is really hard to read and manage. > I loose too much time looking around its code to understand how things works. > So I put my hands in, and applied a few refactoring. > I already removed 2200 lines of code (50Kbytes of code) while keeping the > same functionality (only refactorings). > Of course refactorings like this are not always an easy change: I also remove > the StoreProcessor/FolderProcessor/MessageProcessor granular creation by > refactoring them to top level reentrant objects that take things to process > as arguments to their "process" method. > MessageProcessor is still a mess, but I think this is more selfdocumenting > than before. > I can clean up things much more and update documentation and so on, but I > would like to know if this kind of update is welcome or not, before loosing > too much time. > Stefano -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
