-1. reason: from my experience, commenting out unit tests leads to a degeneration of the test base as a whole, on the long run making the unit tests more or less useless. a small improvement or fix does not justify leaving our tests compromised.
instead, we should do one if the following o back out the original commit causing the test to fail - bad, because this committer does not care for the unit test, so does not care for quality? o fix the test immediately, because it gets harder every day it is not done o let us simply have the breaking test until it gets fixed - bad, because some tests are not run anymore but maybe we need some more days until it gets fixed, which is fine. Bernd On 11/10/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: norman Date: Fri Nov 10 01:37:09 2006 New Revision: 473287 URL: http://svn.apache.org/viewvc?view=rev&rev=473287 Log: Comment a broken test Modified: james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java Modified: james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java URL: http://svn.apache.org/viewvc/james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java?view=diff&rev=473287&r1=473286&r2=473287 ============================================================================== --- james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java (original) +++ james/server/trunk/src/test/org/apache/james/smtpserver/SMTPServerTest.java Fri Nov 10 01:37:09 2006 @@ -1017,7 +1017,10 @@ assertEquals("expected 250 ok", 250, smtpProtocol.getReplyCode()); } - +/** + * Noel please fix me! + * + public void testConnectionLimitExceeded() throws Exception { m_testConfiguration.setConnectionLimit(1); // allow no more than one connection at a time finishSetUp(m_testConfiguration); @@ -1043,7 +1046,7 @@ smtpProtocol2.connect("127.0.0.1", m_smtpListenerPort); assertTrue(smtpProtocol2.isConnected()); } - +*/ // RemoteDelivery tests. InMemorySpoolRepository outgoingSpool; --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
