On 3/23/07, Steve Brewin <[EMAIL PROTECTED]> wrote:
robert burrell donkin wrote:
>
> the documentation on http://james.apache.org/jsieve/index.html looks a
> little sparse to me. i find that writing up documentation is often
> useful when learning a new technology. shall i go ahead and create a
> JIRA or just commit these changes?
Just going ahead is fine by me.
cool
hopefully you'll jump in and highlight any points i've misunderstood
> http://james.apache.org/jsieve/pmd.html lists a number of rule
> violations. from the look of it, these are all cosmetic or stylistic.
> i'd be happy to dive in and fix them if they need fixing. shall i go
> ahead and create a JIRA or just commit these changes?
As you say, most "violations" are cosmetic or stylistic and just someone's
point of view captured as PMD rules. We don't mandate anything beyond
conformance to Sun's guidelines and personally I wouldn't bother fixing
anything other than violations of these.
If you have the itch, fine. Just a warning though, if you start scratching
this itch and apply it to the rest of the codebase its likely to become an
ugly rash :)
Oh! Also remember that some of the classes are generated. There's no point
fixing these as your efforts will be zapped by the next build!
that itch has gone away for now :-)
i've finished a MailAdapter that i can use to test SIEVE scripts.
basically, it wraps a javamail message and preserves a recording of
the actions accumulated when execute was called. this should allow me
to test the (rather long) sieve script i spent last week generating
from my client side filtering rules (in the end i used groovy since
the XSLT was becoming unreadable).
perhaps a sieve script check is something that others might find
useful. shall i tidy it up and commit?
- robert
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
