Robert Burrell Donkin (JIRA) ha scritto: > [ > https://issues.apache.org/jira/browse/JSIEVE-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518827 > ] > > Robert Burrell Donkin commented on JSIEVE-5: > -------------------------------------------- > > ...Grrrr...Don't get me started on J2EE classloaders... > > Really wants to be refactored so that a suitable interface is injected but > > try > { > return > Thread.currentThread().getContextClassLoader().getResourceAsStream(getConfigName()); > } > catch > { > return ClassLoader.getSystemResourceAsStream(getConfigName()); > } > > might work well enough for now. > > Opinions?
Inside JAMES Server code I used Thread.currentThread().getContextClassLoader().getResourceAsStream() without the fallback to the ClassLoader.getSystemResourceAsStream, but this seems even more safe, so +1. Stefano PS: Anyone else noticed that most of jSieve code have curly brackets in the wrong places (I mean different from most of JAMES code)? >> You'd better change the way you load sieveConfig.xml >> ---------------------------------------------------- >> >> Key: JSIEVE-5 >> URL: https://issues.apache.org/jira/browse/JSIEVE-5 >> Project: jSieve >> Issue Type: Improvement >> Reporter: Vladimir >> >> I've placed sieveConfig.xml in jsieve's jar (I think that might be much >> better if you use jsieve as a library). >> You'd better change in ConfigurationManager method: getConfigStream >> this: return ClassLoader.getSystemResourceAsStream(getConfigName()); >> with this: >> return >> Thread.currentThread().getContextClassLoader().getResourceAsStream(getConfigName()); >> ClassLoader doesn't load config if you use jsieve as a library > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
