Am Donnerstag, den 19.06.2008, 13:38 +0200 schrieb Stefano Bagnara: > Bernd Fondermann ha scritto: > > On Wed, Jun 18, 2008 at 1:34 PM, Stefano Bagnara <[EMAIL PROTECTED]> wrote: > >> Robert Burrell Donkin ha scritto: > >>> On Mon, Jun 16, 2008 at 9:38 PM, Rick McGuire <[EMAIL PROTECTED]> wrote: > >>>> Stefano Bagnara wrote: > >>>>> We also depend on com.sun.mail.util.CRLFOutputStream but we should > >>>>> definitely replace this with some james class (maybe copied from > >>>>> geronimo?) > >>>> Not sure what this class does, so I don't know if Geronimo has a > >>>> replacement. I suspect you'd be better off implementing your own though, > >>>> just for implementation independence. > >>> if the class does what it says on the tin then JAMES already has at > >>> least one replacement > >> I cannot find an OutputStream class for that in JAMES: we have > >> inputstream/reader stuff and we have imap utils to take care of this in > >> byte > >> arrays. > >> > >> I found the org.apache.commons.net.io.ToNetASCIIOutputStream class in > >> commons-net, should we use it instead of > >> com.sun.mail.util.CRLFOutputStream? > >> We currently have almost 10 classes in various modules depending on > >> CRLFOutputStream. > >> > >> Stefano > > > > Its worth giving a try. > > +1 > > > I think the main difference is that CRLFOutputStream replace single \r > AND \n in \r\n, while ToNetASCIIOutputStream simply replace \n with > \r\n while it leave lonely \r as is. > > AFAICT this will be ok 99.9% of times with issues only when trying to > use telnet like applications on old apple os, but it is a little less > compliant. > > In order to avoid coupling to com.sun I would probably favor moving to > ToNetASCIIOutputStream anyway. If anyone volounteer for writing a > "complete" CRLFOutputStream this would be the best, but in the mean time... > > Stefano >
+1 Norman --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
