[
https://issues.apache.org/jira/browse/MIME4J-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616166#action_12616166
]
Stefano Bagnara commented on MIME4J-65:
---------------------------------------
There are no more copies than before: I moved copies from the TempBody
implementations to the Entity/Message class. There are no more copies
(excluding the one specific to the bug fixed, that previously was not handled
at all).
I don't think there is more buffering than before for the cases that was
handled before too.
Base64Encoder has a 1024 buffer. Base64OutputStream has a 4 bytes buffer.
I tested the performance too:
I'm creating 10000 random byte sequences from 1 to 1000 bytes long (cannot test
longer messages as the current implementation fails to correctly encode them).
Here are the results:
Encoder: 2538ms
Stream: 2819ms
So the stream solution is 10% slower, but we should consider that the specific
test give the encoder solution
a big advantage in the fact that they always use its own 1024 buffer once and
do not require iterations. There is no way to have a better comparison unless
we fix the Encoder first. I don't care to fix it to prove the performance is
not an issue.
mime4j is far from being usable from me, so I don't care of specific issues or
specific apis too. I just wanted to exercise on this issues. At least I can use
mime4j for testing purposes.
I never pushed. The community simply is upset anytime I make a move. E.g: it
seems that you are getting so upset simply because I'm opening JIRAs with bugs
and attacching proposals to fix them.
I thought that I would have seen a lot of bug fixing now that the test suite
issue or the branch issue is not more blocking you all, too.
I've done my homework and attached stuff to JIRA (it seems it was the only
place I could use without hurting people) as I don't really like the current
place and the current feelings.
If anyone wants an usable DOM api they will take care of this issue and to push
it. Not me. I hope they will appreciate my attempt and that this JIRA does not
hurt anyone.
> Message.writeTo for an rfc822 part ignoring a "base64" encoding
> ---------------------------------------------------------------
>
> Key: MIME4J-65
> URL: https://issues.apache.org/jira/browse/MIME4J-65
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4, 0.5
>
> Attachments: MIME4J-65-complete.patch, MIME4J-65.patch,
> testmsgs-message-rfc822-encoding.zip
>
>
> the writeTo method for a Content-Transfer-Encoding: base64 and Content-Type:
> message/rfc822 part writes the message unencoded.
> I would expect it to be encoded in a base64 stream. See MIME4J-64 for an
> useful test.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
