Stefano Bagnara wrote:
Bernd Fondermann ha scritto:
Robert Burrell Donkin wrote:
http://people.apache.org/~rdonkin/0.2RC2/

please take a look and see if there's any more issues

apache-jsieve-0.2RC2.jar contains the test classes. do we want this?
As a naive user, I'd expect the jar file to only contain what I need for production. (Not a showstopper for me, since it hurts nobody.)

I don't see Junit tests in the apache-jsieve-0.2RC2.jar file. Maybe you've been fooled by the org.apache.jsieve.tests package.

This is not a Junit test package, but a JSieve Tests package. Tests are a domain aspect of Sieve.

They include all of the tests you can run against an input message. You can think of them as Rules or Matchers, but Sieve RFC name them tests, so jSieve package follow the same naming convention.

oh, interesting! didn't know that.


http://www.ietf.org/rfc/rfc3028.txt
2.5.     Tests
2.5.1.   Test Lists

I don't know why, but the pom contains some <exclusion> sections under
  <dependencies>/<dependency>/<exclusions>
which seem to me like they are not neccessary. (Could it be that maven is just there to make me ask stupid questions? ;-))

If you refer to the commons-logging exclusions they are there because commons-logging 1.1 have that as dependencies so they was imported by maven. commons-logging 1.1.1 fixed this and declared them as "optional", so the exclusions should not be necessary any more, but when we updated the commmons-logging version we didn't check for this.

So, I guess they could be removed now, but this have to be tested.

ok, no problem, just noting.

thanks for explaining!,

  Bernd

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to