Markus Wiederkehr ha scritto: > I have written a new Base64OutputStream for Mime4j. According to my > tests it is about twice as fast as the current one (when fed with 1024 > byte blocks).
Good! > It also resolves a tiny issue: the current implementation still > appends _two_ CRLFs at the end of the encoded data if the input data > size is a multiple of 57 bytes. The number of ending CRLF in quoted-printable and base64 encoded parts always puzzled me. I never found a clear explanation in the RFC about what CRLF have to be added and what not. :-( > But now what? Is this a case of review-then-commit or > commit-then-review? Do I have to file a JIRA? Or may I just make use > of my new "karma"? We run all of james product with CTR (commit then review). For stable branches and for code that you are not confident with, and anytime you feel it better, it is suggested the use of RTC (in this case I'd use CTR). For most task we are used creating a JIRA issue when we're working on the issue: this let people know what you are doing and also allow easy tracking (also historical) of the change. About this specific commit you can reuse (reopen) https://issues.apache.org/jira/browse/MIME4J-71 or at least reference also it. As Norman suggested if you use the jira issue name (e.g: MIME4J-71) in the commit comment text the whole commit will appear in the "Subversion Commits" tab in the JIRA issue (few minutes later). Stefano --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
