[
https://issues.apache.org/jira/browse/MIME4J-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658551#action_12658551
]
Oleg Kalnichevski commented on MIME4J-92:
-----------------------------------------
Hi Markus,
Sorry for getting back to you so late. Been busy getting a new release of
HttpClient out the door.
Overall, great stuff. I just one minor nitpick, which is not terribly
important. I generally prefer something like IllegalStateException to asserts,
as lots of people out there do not have them enabled per default, which kind of
makes them pointless. Feel free to ignore.
Oleg
PS: Actually we should also consider fixing QuotedPrintableInputStream, which
has the same problem of reading one byte at a time.
> Replace Base64InputStream with a faster version
> -----------------------------------------------
>
> Key: MIME4J-92
> URL: https://issues.apache.org/jira/browse/MIME4J-92
> Project: JAMES Mime4j
> Issue Type: Improvement
> Affects Versions: 0.5
> Reporter: Markus Wiederkehr
> Assignee: Markus Wiederkehr
> Fix For: 0.6
>
> Attachments: Base64InputStreamSpeedTest.java
>
>
> The current Base64InputStream does not make use of block operations. It
> overrides InputStream.read() instead of InputStream.read(byte[]) and also
> uses the single-byte read method to read from the underlying input stream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
