[ 
https://issues.apache.org/jira/browse/MIME4J-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659335#action_12659335
 ] 

Markus Wiederkehr commented on MIME4J-93:
-----------------------------------------

In my opinion having line number information in the debug output is nice but 
not really that important.

I am currently away from my desktop so it's a bit more complicated than usual 
to look into the source but from what I see the line number information is used 
mainly by AbstractEntity.monitor(Event). This method is used to report invalid 
headers and premature ends of headers or bodies. In any case I would know where 
to look without having an exact line number..

So I second Oleg's opinion to make the class optional. I think it could even be 
deprecated or removed.

But the class serves a second purpose that should probably be retained. It can 
truncate the underlying stream, that is, make it appear as if it were closed 
without actually closing it.

> The use of RootInputStream degrades performance by 50%
> ------------------------------------------------------
>
>                 Key: MIME4J-93
>                 URL: https://issues.apache.org/jira/browse/MIME4J-93
>             Project: JAMES Mime4j
>          Issue Type: Improvement
>    Affects Versions: 0.5
>            Reporter: Oleg Kalnichevski
>             Fix For: 0.6
>
>
> I have never been a big fan of RootInputStream, because it simply does not 
> work correctly for messages with binary coded parts. Please consider making 
> RootInputStream optional, so one could eliminate it from the input filer 
> chain entirely or disable line counting. This should result in a noticeable 
> performance boost (up to 50%)
> Oleg

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to