[ 
https://issues.apache.org/jira/browse/JSIEVE-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734180#action_12734180
 ] 

Robert Burrell Donkin commented on JSIEVE-56:
---------------------------------------------

There is no concurrent usage in JSieve. A caller might reasonably elect to 
reuse the same MailAdapter, for example by sharing the same adapter across 
multiple script for different users. This is unlikely to be a common use case, 
and the implementor could reasonably just use a ThreadLocal to store the 
context.

Give that it isn't clear which methods in the API a context may be required 
for, it seems better to opt for the setter. 

Unless anyone jumps in with an objection, I'll implement something along these 
lines.

> Provide a way to determine if a keep action is implicit or explicit
> -------------------------------------------------------------------
>
>                 Key: JSIEVE-56
>                 URL: https://issues.apache.org/jira/browse/JSIEVE-56
>             Project: JAMES jSieve
>          Issue Type: Improvement
>          Components: JSieve (Main)
>    Affects Versions: 0.3
>            Reporter: Boris Burtin
>
> There's no way to distinguish an implicit keep from an explicit keep in 
> jSieve 0.3.  The Zimbra code needs this distinction because implicit keeps 
> are affected by spam filtering and explicit keeps are not.  This was possible 
> in jSieve 0.2 with CommandStateManager.getInstance().isImplicitKeep(), but no 
> longer possible in 0.3 after the changes for JSIEVE-26.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to