Author: rdonkin
Date: Wed Aug 19 11:29:17 2009
New Revision: 805749

URL: http://svn.apache.org/viewvc?rev=805749&view=rev
Log:
Switched StringBuffer to Builder and improved naming

Added:
    
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/AbstractLoader.java
      - copied, changed from r805747, 
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/Loader.java
Removed:
    
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/Loader.java
Modified:
    
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesMailetLoader.java
    
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesMatcherLoader.java

Copied: 
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/AbstractLoader.java
 (from r805747, 
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/Loader.java)
URL: 
http://svn.apache.org/viewvc/james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/AbstractLoader.java?p2=james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/AbstractLoader.java&p1=james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/Loader.java&r1=805747&r2=805749&rev=805749&view=diff
==============================================================================
--- 
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/Loader.java
 (original)
+++ 
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/AbstractLoader.java
 Wed Aug 19 11:29:17 2009
@@ -47,7 +47,7 @@
  *
  * $Id$
  */
-public abstract class Loader extends AbstractLogEnabled implements 
Serviceable, Configurable, Initializable {
+public abstract class AbstractLoader extends AbstractLogEnabled implements 
Serviceable, Configurable, Initializable {
 
     protected String baseDirectory = null;
     protected final String MAILET_PACKAGE = "mailetpackage";

Modified: 
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesMailetLoader.java
URL: 
http://svn.apache.org/viewvc/james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesMailetLoader.java?rev=805749&r1=805748&r2=805749&view=diff
==============================================================================
--- 
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesMailetLoader.java
 (original)
+++ 
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesMailetLoader.java
 Wed Aug 19 11:29:17 2009
@@ -34,7 +34,7 @@
  * Loads Mailets for use inside James.
  *
  */
-public class JamesMailetLoader extends Loader implements MailetLoader {
+public class JamesMailetLoader extends AbstractLoader implements MailetLoader {
     
     private ServiceLocator serviceLocator;
      
@@ -85,8 +85,8 @@
                     //do this so we loop through all the packages
                 }
             }
-            StringBuffer exceptionBuffer =
-                new StringBuffer(128)
+            StringBuilder exceptionBuffer =
+                new StringBuilder(128)
                     .append("Requested mailet not found: ")
                     .append(mailetName)
                     .append(".  looked in ")
@@ -95,8 +95,8 @@
         } catch (MessagingException me) {
             throw me;
         } catch (Exception e) {
-            StringBuffer exceptionBuffer =
-                new StringBuffer(128).append("Could not load mailet 
(").append(mailetName).append(
+            StringBuilder exceptionBuffer =
+                new StringBuilder(128).append("Could not load mailet 
(").append(mailetName).append(
                     ")");
             throw new MailetException(exceptionBuffer.toString(), e);
         }

Modified: 
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesMatcherLoader.java
URL: 
http://svn.apache.org/viewvc/james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesMatcherLoader.java?rev=805749&r1=805748&r2=805749&view=diff
==============================================================================
--- 
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesMatcherLoader.java
 (original)
+++ 
james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/JamesMatcherLoader.java
 Wed Aug 19 11:29:17 2009
@@ -30,7 +30,7 @@
  * Loads Matchers for use inside James.
  *
  */
-public class JamesMatcherLoader extends Loader implements MatcherLoader {
+public class JamesMatcherLoader extends AbstractLoader implements 
MatcherLoader {
     /**
      * @see 
org.apache.avalon.framework.configuration.Configurable#configure(Configuration)
      */
@@ -63,8 +63,8 @@
                     //do this so we loop through all the packages
                 }
             }
-            StringBuffer exceptionBuffer =
-                new StringBuffer(128)
+            StringBuilder exceptionBuffer =
+                new StringBuilder(128)
                     .append("Requested matcher not found: ")
                     .append(matchName)
                     .append(".  looked in ")
@@ -73,8 +73,8 @@
         } catch (MessagingException me) {
             throw me;
         } catch (Exception e) {
-            StringBuffer exceptionBuffer =
-                new StringBuffer(128).append("Could not load matcher 
(").append(matchName).append(
+            StringBuilder exceptionBuffer =
+                new StringBuilder(128).append("Could not load matcher 
(").append(matchName).append(
                     ")");
             throw new MailetException(exceptionBuffer.toString(), e);
         }



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to