[ 
https://issues.apache.org/jira/browse/IMAP-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901143#action_12901143
 ] 

Eric Charles commented on IMAP-206:
-----------------------------------

I've svn up --revision 987444 and tried to apply the patch, but it's 
complaining files are not present (Mapper, AbstractTransactionalMapper, 
TransactionalMapper).
Never mind, with the explanation you gave, I now understand much better the way 
mappers should be considered.
So if james store is still working with that hierarchy, I would like to see it 
in trunk.


> Straighten Non-/TransactionalMapper Hierarchy
> ---------------------------------------------
>
>                 Key: IMAP-206
>                 URL: https://issues.apache.org/jira/browse/IMAP-206
>             Project: JAMES Imap
>          Issue Type: Improvement
>            Reporter: Tim-Christian Mundt
>            Priority: Minor
>         Attachments: TransactionalMappers.patch
>
>
> There are two things I find odd about the Mapper hierarchy:
> a) NonTransactionalMapper extends TransactionalMapper which is semantically 
> confusing.
> b) The Store API refers to TransactionalMappers where any Mapper 
> (transactional or not) is appropriate. Moreover, the Mappers inherit from 
> TransactionalMapper two times: once via AbstractTransactionalMapper and once 
> via Message/Mailbox/SubscriptionMapper.
> I'd like to have it more straight forward:
> 1) Have a base Mapper, which gets implemented by a TransactionalMapper and a 
> NonTransactionalMapper (both abstract).
> 2) The Message/Mailbox/SubscriptionMapper interfaces should not care about 
> transactions and thus not inherit at all.
> 3) The implementations extend one of Transactional- or NonTransactionalMapper 
> and implement one of Message/Mailbox/SubscriptionMapper.
> This way the hierarchy is clearer and function (message...) and transaction 
> are separated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to