Author: eric
Date: Mon Jan  3 13:57:00 2011
New Revision: 1054618

URL: http://svn.apache.org/viewvc?rev=1054618&view=rev
Log:
Throw exception instead of returning a boolean + Better manage the already 
existing mailboxes (MAILBOX-19)

Modified:
    
james/server/trunk/container-spring/src/main/java/org/apache/james/container/spring/mailbox/MailboxCopierManagement.java
    
james/server/trunk/container-spring/src/main/java/org/apache/james/container/spring/mailbox/MailboxCopierManagementMBean.java

Modified: 
james/server/trunk/container-spring/src/main/java/org/apache/james/container/spring/mailbox/MailboxCopierManagement.java
URL: 
http://svn.apache.org/viewvc/james/server/trunk/container-spring/src/main/java/org/apache/james/container/spring/mailbox/MailboxCopierManagement.java?rev=1054618&r1=1054617&r2=1054618&view=diff
==============================================================================
--- 
james/server/trunk/container-spring/src/main/java/org/apache/james/container/spring/mailbox/MailboxCopierManagement.java
 (original)
+++ 
james/server/trunk/container-spring/src/main/java/org/apache/james/container/spring/mailbox/MailboxCopierManagement.java
 Mon Jan  3 13:57:00 2011
@@ -18,12 +18,14 @@
  ****************************************************************/
 package org.apache.james.container.spring.mailbox;
 
+import java.io.IOException;
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.Map;
 
 import javax.annotation.Resource;
 
+import org.apache.james.mailbox.MailboxException;
 import org.apache.james.mailbox.MailboxManager;
 import org.apache.james.mailbox.copier.MailboxCopier;
 import org.springframework.beans.BeansException;
@@ -49,6 +51,7 @@ public class MailboxCopierManagement imp
      * @see 
org.apache.james.container.spring.mailbox.MailboxCopierManagementMBean#getMailboxManagerBeans()
      */
     public Map<String,String> getMailboxManagerBeans() {
+        
         Map<String, String> bMap = new HashMap<String, String>();
        
         Map<String,MailboxManager> beans = 
context.getBeansOfType(MailboxManager.class);
@@ -66,9 +69,9 @@ public class MailboxCopierManagement imp
      * (non-Javadoc)
      * @see 
org.apache.james.container.spring.mailbox.MailboxCopierManagementMBean#copy(java.lang.String,
 java.lang.String)
      */
-    public boolean copy(String srcBean, String dstBean) {
+    public void copy(String srcBean, String dstBean) throws MailboxException, 
IOException {
         if (srcBean.equals(dstBean)) throw new 
IllegalArgumentException("srcBean and dstBean can not have the same name!");
-        return copier.copyMailboxes(context.getBean(srcBean, 
MailboxManager.class), context.getBean(dstBean, MailboxManager.class));
+        copier.copyMailboxes(context.getBean(srcBean, MailboxManager.class), 
context.getBean(dstBean, MailboxManager.class));
     }
 
     

Modified: 
james/server/trunk/container-spring/src/main/java/org/apache/james/container/spring/mailbox/MailboxCopierManagementMBean.java
URL: 
http://svn.apache.org/viewvc/james/server/trunk/container-spring/src/main/java/org/apache/james/container/spring/mailbox/MailboxCopierManagementMBean.java?rev=1054618&r1=1054617&r2=1054618&view=diff
==============================================================================
--- 
james/server/trunk/container-spring/src/main/java/org/apache/james/container/spring/mailbox/MailboxCopierManagementMBean.java
 (original)
+++ 
james/server/trunk/container-spring/src/main/java/org/apache/james/container/spring/mailbox/MailboxCopierManagementMBean.java
 Mon Jan  3 13:57:00 2011
@@ -18,8 +18,10 @@
  ****************************************************************/
 package org.apache.james.container.spring.mailbox;
 
+import java.io.IOException;
 import java.util.Map;
 
+import org.apache.james.mailbox.MailboxException;
 import org.apache.james.mailbox.MailboxManager;
 
 /**
@@ -35,7 +37,7 @@ public interface MailboxCopierManagement
      * 
      * @return managers
      */
-    public Map<String,String> getMailboxManagerBeans();
+    Map<String,String> getMailboxManagerBeans();
     
     /**
      * Copy from srcBean to dstBean all messages
@@ -44,5 +46,6 @@ public interface MailboxCopierManagement
      * @param dstBean
      * @return true if successful, false otherwise
      */
-    public boolean copy(String srcBean, String dstBean);
+    void copy(String srcBean, String dstBean) throws MailboxException, 
IOException;
+    
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to