[ 
https://issues.apache.org/jira/browse/JAMES-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031733#comment-13031733
 ] 

Stefano Bagnara commented on JAMES-1237:
----------------------------------------

What did changes to make you switch to "must-have" ? I'm still in the "not a 
good idea" state, so I'd be happy to understand what are the points that moved 
you.

Most spring code in james server related to imap and mailbox is james-server 
specific and adding more spring stuff in mailbox and imap won't help reducing 
the spring code in server.

What are the "demployment options" that this would bring? I don't see what a 
mailbox-spring and mailbox-guice modules would provide to the end 
user/developers, and having such modules sounds countrary to the spirit of 
guice/spring. 

About your examples: cfx, camel, activemq , they embrace spring as their 
platform and not simply use it as "an optional, agnostic, container". I think 
this is something to take into consideration. They define impoved syntaxes 
(DSL) for spring configuration files, adapters for spring types and much more. 
I don't think that mailbox needs this stuff (and imap doesn't seem to have much 
more configuration). Currently we are far from using spring this way.. I think 
you are over-rating the power of adding a mailbox-spring.xml file in the 
mailbox project. If the goal is to help developers use the mailbox library then 
the api should be made more easy (there is plenty to do as suggested in the 
thread I linked previously).

That said, you are active, I'm passive, so you should simply go ahead with your 
idea. I'm sure we'll better understand the advantages/disadvantages once 
something is done for real.


> Reorganize system configuration files (spring context, xsd)
> -----------------------------------------------------------
>
>                 Key: JAMES-1237
>                 URL: https://issues.apache.org/jira/browse/JAMES-1237
>             Project: JAMES Server
>          Issue Type: Improvement
>          Components: Deployment Modules
>            Reporter: Eric Charles
>
> There is a trend for configuration/properties files to be placed in META-INF 
> (look at cxf, camel, maven,... distributions).
> Also, I think the injection of dependent project (mailbox, imap) should not 
> be defined in server, but in the project it self.
> We could have the same approach and define a META-INF/james to hold those 
> files
> The server context could go to META-INF/james/server-spring.xml, and we could 
> move the definitions related to mailbox,imap to their respective project 
> (with the same strategy, in  META-INF/james/mailbox-spring.xml,...)
> For the embedded XSD I'm not sure if thy need to go to 
> META-INF/james/org.apache.activemq,... or META-INF/activemq/
> In all cases, the user can stilll override the defintions at deployment time 
> simply by defining the files in the conf folder (conf is on top of the 
> classpath).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to