Hi,

I am exciting about james 3.0 project and I have it in production. I would like to suggest the following change in org.apache.james.protocols.smtp.core.esmtp.AuthCmdHandler.java

- // TODO: Make this string a more useful error message
- session.getLogger().error("AUTH method "+authType+" failed");
+ session.getLogger().error("AUTH method "+authType+" failed from " + user + "@" + session.getRemoteIPAddress());

The reason is to be able to analyse messages such as :

ERROR 17:43:37,421 | james.smtpserver | AUTH method LOGIN failed
ERROR 17:43:37,697 | james.smtpserver | AUTH method LOGIN failed
ERROR 17:43:38,027 | james.smtpserver | AUTH method LOGIN failed
ERROR 17:43:38,244 | james.smtpserver | AUTH method LOGIN failed
ERROR 17:43:38,477 | james.smtpserver | AUTH method LOGIN failed
ERROR 17:43:38,806 | james.smtpserver | AUTH method LOGIN failed
ERROR 17:43:38,981 | james.smtpserver | AUTH method LOGIN failed
ERROR 17:43:39,117 | james.smtpserver | AUTH method LOGIN failed
ERROR 17:43:39,414 | james.smtpserver | AUTH method LOGIN failed
ERROR 17:43:39,722 | james.smtpserver | AUTH method LOGIN failed
ERROR 17:43:40,011 | james.smtpserver | AUTH method LOGIN failed
ERROR 17:43:40,243 | james.smtpserver | AUTH method LOGIN failed

So I can ban them from my network ...

Thanks a lot !
Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to