Author: norman
Date: Wed Aug 10 13:00:13 2011
New Revision: 1156160

URL: http://svn.apache.org/viewvc?rev=1156160&view=rev
Log:
log errors when parsing addresses. 

Modified:
    
james/server/trunk/queue-jms/src/main/java/org/apache/james/queue/jms/JMSMailQueue.java

Modified: 
james/server/trunk/queue-jms/src/main/java/org/apache/james/queue/jms/JMSMailQueue.java
URL: 
http://svn.apache.org/viewvc/james/server/trunk/queue-jms/src/main/java/org/apache/james/queue/jms/JMSMailQueue.java?rev=1156160&r1=1156159&r2=1156160&view=diff
==============================================================================
--- 
james/server/trunk/queue-jms/src/main/java/org/apache/james/queue/jms/JMSMailQueue.java
 (original)
+++ 
james/server/trunk/queue-jms/src/main/java/org/apache/james/queue/jms/JMSMailQueue.java
 Wed Aug 10 13:00:13 2011
@@ -402,13 +402,14 @@ public class JMSMailQueue implements Man
         String recipients = message.getStringProperty(JAMES_MAIL_RECIPIENTS);
         StringTokenizer recipientTokenizer = new StringTokenizer(recipients, 
JAMES_MAIL_SEPARATOR);
         while (recipientTokenizer.hasMoreTokens()) {
+               String token = recipientTokenizer.nextToken();
             try {
-                MailAddress rcpt = new 
MailAddress(recipientTokenizer.nextToken());
+                MailAddress rcpt = new MailAddress(token);
                 rcpts.add(rcpt);
             } catch (AddressException e) {
                 // Should never happen as long as the user does not modify the
                 // the header by himself
-                // Maybe we should log it anyway
+               logger.error("Unable to parse the recipient address " + token + 
" for mail " + mail.getName() + ", so we ignore it", e);
             }
         }
         mail.setRecipients(rcpts);
@@ -443,7 +444,8 @@ public class JMSMailQueue implements Man
             } catch (AddressException e) {
                 // Should never happen as long as the user does not modify the
                 // the header by himself
-                // Maybe we should log it anyway
+               logger.error("Unable to parse the sender address " + sender + " 
for mail " + mail.getName() + ", so we fallback to a null sender", e);
+               mail.setSender(null);
             }
         }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to