On 09/28/2011 01:09 PM, Norman Maurer wrote:
But isn't this just the implementation of the interface method ? Or do
I miss something ?

I missunderstood would you meant by interface implementation. I thought about something like

public interface MessageSearchIndex<Id> {
Iterator<Long> search(MailboxSession session, Mailbox<Id> mailbox, SearchQuery searchQuery) throws MailboxException {
        return EmptyIterator;
    }
}

But anyway ... You're right, using JDK 6 you can annotate @Override also interface definition in the implementing class having the benefit that one is on the very safe side if ever the annotated method doesn't comes from an interface but from a superclass.

Thanks for enlightment :-) I'll revert it.

Regards Felix


Bye,
Norman



2011/9/28 Felix Knecht<[email protected]>:
On 09/28/2011 12:59 PM, Norman Maurer wrote:

Isn't this because of jdk 1.6 which also "supports" @override for
interface implementations ?

I don't now :-/

But there is not interface implementation I think:

public interface MessageSearchIndex<Id>  {

    /**
     * Return all uids of the previous indexed {@link MailboxMembership}'s
which match the {@link SearchQuery}
     *
     * @param mailbox
     * @param searchQuery
     * @return
     * @throws MailboxException
     */
    Iterator<Long>  search(MailboxSession session, Mailbox<Id>  mailbox,
SearchQuery searchQuery) throws MailboxException;
}

Regards
Felix


Bye,
Norman


2011/9/28<[email protected]>:

Author: felixk
Date: Wed Sep 28 10:54:06 2011
New Revision: 1176817

URL: http://svn.apache.org/viewvc?rev=1176817&view=rev
Log:
Does not override anything from super class

Modified:

  
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java

Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java?rev=1176817&r1=1176816&r2=1176817&view=diff

==============================================================================
---
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java
(original)
+++
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java
Wed Sep 28 10:54:06 2011
@@ -70,7 +70,6 @@ public class LazyMessageSearchIndex<Id>
      * complete
      *
      */
-    @Override
     public Iterator<Long>    search(final MailboxSession session, final
Mailbox<Id>    mailbox, SearchQuery searchQuery) throws MailboxException {
         Id id = mailbox.getMailboxId();




---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to