Author: norman
Date: Wed Jan 11 14:33:52 2012
New Revision: 1230066

URL: http://svn.apache.org/viewvc?rev=1230066&view=rev
Log:
More cleanup

Removed:
    
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/TemporaryResolutionException.java
Modified:
    
james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/StreamResponse.java
    
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPConfiguration.java
    
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPConfigurationImpl.java
    
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/DataLineMessageHookHandler.java
    
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/ReceivedDataLineFilter.java
    
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/WelcomeMessageHandler.java
    
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/hook/DeliverToRecipientHook.java
    
james/protocols/trunk/netty/src/main/java/org/apache/james/protocols/netty/NettyProtocolTransport.java
    
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Configuration.java
    
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Protocol.java
    
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3ProtocolHandlerChain.java
    
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3StreamResponse.java
    
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/core/TopCmdHandler.java
    
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/mailbox/MailboxFactory.java
    
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/mailbox/MessageMetaData.java
    
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/MailEnvelope.java
    
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPConfigurationImpl.java
    
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPProtocolHandlerChain.java
    
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPSession.java

Modified: 
james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/StreamResponse.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/StreamResponse.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/StreamResponse.java
 (original)
+++ 
james/protocols/trunk/api/src/main/java/org/apache/james/protocols/api/StreamResponse.java
 Wed Jan 11 14:33:52 2012
@@ -29,7 +29,8 @@ import java.io.InputStream;
 public interface StreamResponse extends Response{
 
     /**
-     * Return the stream which needs to get written to the remote peer
+     * Return the stream which needs to get written to the remote peer. This 
method should only be called one time (when the data is written to the client) 
as it returns
+     * the same {@link InputStream} on every call. So once it is consumed 
there is no way to re-process it.
      * 
      * @return stream
      */

Modified: 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPConfiguration.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPConfiguration.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPConfiguration.java
 (original)
+++ 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPConfiguration.java
 Wed Jan 11 14:33:52 2012
@@ -21,38 +21,38 @@ package org.apache.james.protocols.lmtp;
 import org.apache.james.protocols.api.ProtocolConfigurationImpl;
 import org.apache.james.protocols.smtp.SMTPConfiguration;
 
+
+/**
+ * A {@link ProtocolConfigurationImpl} which is used in the context of LMTP
+ *
+ */
 public abstract class LMTPConfiguration extends ProtocolConfigurationImpl 
implements SMTPConfiguration{
 
-    public LMTPConfiguration() {
-        setSoftwareName("JAMES Protocols LMTP Server");
-    }
-    /*
-     * (non-Javadoc)
-     * @see 
org.apache.james.protocols.smtp.SMTPConfiguration#isRelayingAllowed(java.lang.String)
+
+    
+    /**
+     * Return <code>false</code>
      */
     public boolean isRelayingAllowed(String remoteIP) {
         return false;
     }
 
-    /*
-     * (non-Javadoc)
-     * @see 
org.apache.james.protocols.smtp.SMTPConfiguration#isAuthRequired(java.lang.String)
+    /**
+     * Return <code>false</code>
      */
     public boolean isAuthRequired(String remoteIP) {
         return false;
     }
 
-    /*
-     * (non-Javadoc)
-     * @see 
org.apache.james.protocols.smtp.SMTPConfiguration#useHeloEhloEnforcement()
+    /**
+     * Return <code>false</code>
      */
     public boolean useHeloEhloEnforcement() {
         return false;
     }
 
-    /*
-     * (non-Javadoc)
-     * @see 
org.apache.james.protocols.smtp.SMTPConfiguration#useAddressBracketsEnforcement()
+    /**
+     * Return <code>false</code>
      */
     public boolean useAddressBracketsEnforcement() {
         return false;

Modified: 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPConfigurationImpl.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPConfigurationImpl.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPConfigurationImpl.java
 (original)
+++ 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/LMTPConfigurationImpl.java
 Wed Jan 11 14:33:52 2012
@@ -22,6 +22,10 @@ public class LMTPConfigurationImpl exten
 
     private long maxMessageSize = 0;    
 
+    public LMTPConfigurationImpl() {
+        setSoftwareName("JAMES Protocols LMTP Server");
+    }
+    
     /*
      * (non-Javadoc)
      * @see 
org.apache.james.protocols.smtp.SMTPConfiguration#getMaxMessageSize()

Modified: 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/DataLineMessageHookHandler.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/DataLineMessageHookHandler.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/DataLineMessageHookHandler.java
 (original)
+++ 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/DataLineMessageHookHandler.java
 Wed Jan 11 14:33:52 2012
@@ -35,6 +35,11 @@ import org.apache.james.protocols.smtp.S
 import org.apache.james.protocols.smtp.core.AbstractHookableCmdHandler;
 import org.apache.james.protocols.smtp.dsn.DSNStatus;
 
+/**
+ * {@link DataLineMessageHookHandler} which will use the wired {@link 
DeliverToRecipientHook}'s to deliver the message to all the valid recipients.
+ * 
+ *
+ */
 public class DataLineMessageHookHandler extends 
org.apache.james.protocols.smtp.core.DataLineMessageHookHandler{
 
     private final List<DeliverToRecipientHook> handlers = new 
ArrayList<DeliverToRecipientHook>();

Modified: 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/ReceivedDataLineFilter.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/ReceivedDataLineFilter.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/ReceivedDataLineFilter.java
 (original)
+++ 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/ReceivedDataLineFilter.java
 Wed Jan 11 14:33:52 2012
@@ -20,6 +20,11 @@ package org.apache.james.protocols.lmtp.
 
 import org.apache.james.protocols.smtp.SMTPSession;
 
+/**
+ * {@link ReceivedDataLineFilter} which will add the Received header to the 
message
+ * 
+ *
+ */
 public class ReceivedDataLineFilter extends 
org.apache.james.protocols.smtp.core.ReceivedDataLineFilter {
 
     private static final String SERVICE_TYPE = "LMTP";

Modified: 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/WelcomeMessageHandler.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/WelcomeMessageHandler.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/WelcomeMessageHandler.java
 (original)
+++ 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/core/WelcomeMessageHandler.java
 Wed Jan 11 14:33:52 2012
@@ -21,10 +21,16 @@ package org.apache.james.protocols.lmtp.
 
 import org.apache.james.protocols.smtp.SMTPSession;
 
+/**
+ * Returns the WELCOME response to the client after it established a connection
+ * 
+ *
+ */
 public class WelcomeMessageHandler extends 
org.apache.james.protocols.smtp.core.WelcomeMessageHandler {
     
     private final static String SERVICE_TYPE = "LMTP";
 
+    @Override
     protected String getServiceType(SMTPSession session) {
         return SERVICE_TYPE;
     }

Modified: 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/hook/DeliverToRecipientHook.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/hook/DeliverToRecipientHook.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/hook/DeliverToRecipientHook.java
 (original)
+++ 
james/protocols/trunk/lmtp/src/main/java/org/apache/james/protocols/lmtp/hook/DeliverToRecipientHook.java
 Wed Jan 11 14:33:52 2012
@@ -25,6 +25,11 @@ import org.apache.james.protocols.smtp.S
 import org.apache.james.protocols.smtp.hook.Hook;
 import org.apache.james.protocols.smtp.hook.HookResult;
 
+/**
+ * {@link Hook} which can be implemented to handle the delivery of a {@link 
MailEnvelope} to a recipient. This {@link Hook} will get called for each
+ * valid recipient during a transaction
+ *
+ */
 public interface DeliverToRecipientHook extends Hook {
 
     /**

Modified: 
james/protocols/trunk/netty/src/main/java/org/apache/james/protocols/netty/NettyProtocolTransport.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/netty/src/main/java/org/apache/james/protocols/netty/NettyProtocolTransport.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/netty/src/main/java/org/apache/james/protocols/netty/NettyProtocolTransport.java
 (original)
+++ 
james/protocols/trunk/netty/src/main/java/org/apache/james/protocols/netty/NettyProtocolTransport.java
 Wed Jan 11 14:33:52 2012
@@ -136,7 +136,7 @@ public class NettyProtocolTransport exte
 
                 } catch (IOException e) {
                     // We handle this later
-                    channel.write(new ChunkedStream(in));
+                    channel.write(new ChunkedStream(new 
ExceptionInputStream(e)));
                 }
                 return;
 
@@ -152,7 +152,7 @@ public class NettyProtocolTransport exte
 
                         } catch (IOException e) {
                             // We handle this later
-                            channel.write(new ChunkedStream(in));
+                            channel.write(new ChunkedStream(new 
ExceptionInputStream(e)));
                         }                    
                     } else {
                         channel.write(new ChunkedStream(in));
@@ -197,5 +197,25 @@ public class NettyProtocolTransport exte
         // See JAMES-1277
         channel.getPipeline().addBefore(HandlerConstants.CORE_HANDLER, 
"lineHandler" + lineHandlerCount, new LineHandlerUpstreamHandler(session, 
overrideCommandHandler));
     }
+    
+   
+    /**
+     * {@link InputStream} which just re-throw the {@link IOException} on the 
next {@link #read()} operation.
+     * 
+     *
+     */
+    private static final class ExceptionInputStream extends InputStream {
+        private final IOException e;
+
+        public ExceptionInputStream(IOException e) {
+            this.e = e;
+        }
+        
+        @Override
+        public int read() throws IOException {
+            throw e;
+        }
+        
+    }
 
 }

Modified: 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Configuration.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Configuration.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Configuration.java
 (original)
+++ 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Configuration.java
 Wed Jan 11 14:33:52 2012
@@ -20,6 +20,10 @@ package org.apache.james.protocols.pop3;
 
 import org.apache.james.protocols.api.ProtocolConfigurationImpl;
 
+/**
+ * {@link ProtocolConfigurationImpl} which adds some default configuration for 
POP3
+ *
+ */
 public class POP3Configuration extends ProtocolConfigurationImpl {
 
     public POP3Configuration() {

Modified: 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Protocol.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Protocol.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Protocol.java
 (original)
+++ 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Protocol.java
 Wed Jan 11 14:33:52 2012
@@ -26,6 +26,10 @@ import org.apache.james.protocols.api.Pr
 import org.apache.james.protocols.api.handler.ProtocolHandlerChain;
 import org.apache.james.protocols.api.logger.Logger;
 
+/**
+ * {@link ProtocolImpl} which implements the POP3 Protocol
+ *
+ */
 public class POP3Protocol extends ProtocolImpl{
     
     public POP3Protocol(ProtocolHandlerChain chain, ProtocolConfiguration 
config, Logger logger) {

Modified: 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3ProtocolHandlerChain.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3ProtocolHandlerChain.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3ProtocolHandlerChain.java
 (original)
+++ 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3ProtocolHandlerChain.java
 Wed Jan 11 14:33:52 2012
@@ -43,13 +43,17 @@ import org.apache.james.protocols.pop3.c
 import org.apache.james.protocols.pop3.core.WelcomeMessageHandler;
 import org.apache.james.protocols.pop3.mailbox.MailboxFactory;
 
+/**
+ * {@link ProtocolHandlerChainImpl} which allows to add the default handlers 
which are needed to server POP3.
+ * 
+ *
+ */
 public class POP3ProtocolHandlerChain extends ProtocolHandlerChainImpl{
 
     public POP3ProtocolHandlerChain() {
         super();
     }
 
-        
     /**
      * The {@link MailboxFactory} to use. If a <code>not null</code> {@link 
MailboxFactory} is given, the {@link POP3ProtocolHandlerChain}
      * will add all default handlers

Modified: 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3StreamResponse.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3StreamResponse.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3StreamResponse.java
 (original)
+++ 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/POP3StreamResponse.java
 Wed Jan 11 14:33:52 2012
@@ -25,15 +25,23 @@ import java.io.SequenceInputStream;
 
 import org.apache.james.protocols.api.StreamResponse;
 
+/**
+ * {@link StreamResponse} implementation which allows to write back big-data 
to the client for POP3
+ *
+ */
 public class POP3StreamResponse extends POP3Response implements StreamResponse 
{
 
-    private InputStream stream;
+    private final InputStream stream;
 
     public POP3StreamResponse(String code, CharSequence description, 
InputStream stream) {
         super(code, description);
         this.stream = stream;
     }
 
+    /*
+     * (non-Javadoc)
+     * @see org.apache.james.protocols.api.StreamResponse#getStream()
+     */
     public InputStream getStream() {
         return new SequenceInputStream(stream, new 
ByteArrayInputStream(".\r\n".getBytes()));
     }

Modified: 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/core/TopCmdHandler.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/core/TopCmdHandler.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/core/TopCmdHandler.java
 (original)
+++ 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/core/TopCmdHandler.java
 Wed Jan 11 14:33:52 2012
@@ -207,7 +207,7 @@ public class TopCmdHandler extends RetrC
         }
 
         @Override
-        public synchronized void reset() throws IOException {
+        public void reset() throws IOException {
             // do nothing as mark is not supported
         }
 

Modified: 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/mailbox/MailboxFactory.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/mailbox/MailboxFactory.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/mailbox/MailboxFactory.java
 (original)
+++ 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/mailbox/MailboxFactory.java
 Wed Jan 11 14:33:52 2012
@@ -38,6 +38,6 @@ public interface MailboxFactory {
      * @return mailbox or null if not valid user or password was given
      * @throws IOException
      */
-    public Mailbox getMailbox(POP3Session session, String password) throws 
IOException;
+    Mailbox getMailbox(POP3Session session, String password) throws 
IOException;
 
 }

Modified: 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/mailbox/MessageMetaData.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/mailbox/MessageMetaData.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/mailbox/MessageMetaData.java
 (original)
+++ 
james/protocols/trunk/pop3/src/main/java/org/apache/james/protocols/pop3/mailbox/MessageMetaData.java
 Wed Jan 11 14:33:52 2012
@@ -23,8 +23,8 @@ package org.apache.james.protocols.pop3.
  */
 public final class MessageMetaData {
 
-    private long uid;
-    private long size;
+    private final long uid;
+    private final long size;
 
     public MessageMetaData(long uid, long size) {
         this.uid = uid;

Modified: 
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/MailEnvelope.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/MailEnvelope.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/MailEnvelope.java
 (original)
+++ 
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/MailEnvelope.java
 Wed Jan 11 14:33:52 2012
@@ -57,6 +57,8 @@ public interface MailEnvelope {
     /**
      * Return the OutputStream of the message
      * 
+     * TODO: Think about how to remove this!
+     * 
      * @return out
      * @throws IOException
      */

Modified: 
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPConfigurationImpl.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPConfigurationImpl.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPConfigurationImpl.java
 (original)
+++ 
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPConfigurationImpl.java
 Wed Jan 11 14:33:52 2012
@@ -23,6 +23,11 @@ package org.apache.james.protocols.smtp;
 import org.apache.james.protocols.api.ProtocolConfigurationImpl;
 
 
+/**
+ * {@link SMTPConfiguration} implementation which allows to set and get 
various configuration params. The set and get methods
+ * are not thread-safe
+ *
+ */
 public class SMTPConfigurationImpl extends ProtocolConfigurationImpl 
implements SMTPConfiguration{
 
     public String helloName = "localhost";
@@ -34,14 +39,24 @@ public class SMTPConfigurationImpl exten
         setSoftwareName("JAMES SMTP Protocols Server");
     }
     
+    /*
+     * (non-Javadoc)
+     * @see 
org.apache.james.protocols.smtp.SMTPConfiguration#getMaxMessageSize()
+     */
     public long getMaxMessageSize() {
         return maxMessageSize;
     }
 
+    /**
+     * Return <code>false</code>
+     */
     public boolean isRelayingAllowed(String remoteIP) {
         return false;
     }
 
+    /**
+     * Return <code>false</code>
+     */
     public boolean isAuthRequired(String remoteIP) {
         return false;
     }
@@ -51,15 +66,24 @@ public class SMTPConfigurationImpl exten
     }
     
     
+    /*
+     * (non-Javadoc)
+     * @see 
org.apache.james.protocols.smtp.SMTPConfiguration#useHeloEhloEnforcement()
+     */
     public boolean useHeloEhloEnforcement() {
         return enforceHeloEhlo;
     }
     
     
+    /*
+     * (non-Javadoc)
+     * @see 
org.apache.james.protocols.smtp.SMTPConfiguration#useAddressBracketsEnforcement()
+     */
     public boolean useAddressBracketsEnforcement() {
         return bracketsEnforcement;
     }
 
+    
     public void setUseAddressBracketsEnforcement(boolean bracketsEnforcement) {
         this.bracketsEnforcement = bracketsEnforcement;
     }

Modified: 
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPProtocolHandlerChain.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPProtocolHandlerChain.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPProtocolHandlerChain.java
 (original)
+++ 
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPProtocolHandlerChain.java
 Wed Jan 11 14:33:52 2012
@@ -55,11 +55,6 @@ import org.apache.james.protocols.smtp.h
  * the chain to act as full blown SMTPServer. By default messages will just get
  * rejected after the DATA command.
  * 
- * 
- * 
- * 
- * 
- * 
  */
 public class SMTPProtocolHandlerChain extends ProtocolHandlerChainImpl {
     

Modified: 
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPSession.java
URL: 
http://svn.apache.org/viewvc/james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPSession.java?rev=1230066&r1=1230065&r2=1230066&view=diff
==============================================================================
--- 
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPSession.java
 (original)
+++ 
james/protocols/trunk/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPSession.java
 Wed Jan 11 14:33:52 2012
@@ -75,6 +75,5 @@ public interface SMTPSession extends Pro
     int getRcptCount();
     
 
-    
 }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to