[ 
https://issues.apache.org/jira/browse/MAILBOX-157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203472#comment-13203472
 ] 

Eric Charles commented on MAILBOX-157:
--------------------------------------

Hi Jochen

    private MailboxACL readACL(MailboxSession session) throws MailboxException {
        // FIXME Do we need this locking?
        return locker.executeWithLock(session, path, new 
LockAwareExecution<MailboxACL>() {

    private void saveACL(final MailboxACL acl, final MailboxSession session) 
throws MailboxException {
        // FIXME Do we need this locking?
        locker.executeWithLock(session, path, new LockAwareExecution<Void>() {

--> As first shot, I would say "better safer than sorry". I would leave the 
lock execution.

WDYT?
Eric
                
> Review the ACL persistence in MaildirFolder
> -------------------------------------------
>
>                 Key: MAILBOX-157
>                 URL: https://issues.apache.org/jira/browse/MAILBOX-157
>             Project: James Mailbox
>          Issue Type: Task
>          Components: maildir mailbox
>            Reporter: Jochen Gazda
>            Assignee: Norman Maurer
>
> There are two FIXMEs in org.apache.james.mailbox.maildir.MaildirFolder. 
> Further the ACL persistence should be tested.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to