Pe 15.03.2012 13:41, Norman Maurer a scris:
A tab should be four spaces..

bye,
Norman


Hi Norman,

With 4 spaces, the alignment didn't look ok. Now everything looks fine but I wish to double-check with someone else.

Please apply the patch and check if things are the way they should be. If I get green I will commit, if not, I will use 4 spaces.

Cheers,

Von meinem iPad gesendet

Am 15.03.2012 um 12:38 schrieb Ioan Eugen Stan<stan.ieu...@gmail.com>:

2012/3/13 Ioan Eugen Stan<stan.ieu...@gmail.com>:
Pe 13.03.2012 16:30, Eric Charles a scris:

Hi Ioan,

You could play with svn revert or merge, but just replace and commit the
new files.

Eric


I was hoping for a recipe. Looks like I'm not in luck. I will fiddle around
and hope to get things right.

Wish me luck,


Ok, sorry it took this long, but I think I have a solution. I've
attached the diff. Eric, could you apply it and see if it makes things
good before I commit the changes?

I ran commands like:

$find queue-jms/src/test/ -name *.java  -print | xargs sed -i 's/\t/        /g'

To find all java test files and change all tabs from each file into 8
spaces (so alignment would turn out ok).
I've also attached it to
https://issues.apache.org/jira/browse/JAMES-1393 if it doesn't get on
the ml.

I've also unchecked the NetBeans option that ignored white space in diffs.

Cheers,

--
Ioan Eugen Stan
http://ieugen.blogspot.com/
<tabs-fix.patch.gz>

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org



--
Ioan Eugen Stan
http://ieugen.blogspot.com

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to