Hi Ioan,
In the meantime I have committed a fix.
It should be all right now.
Thx, Eric
On 09/01/2013 11:13, Ioan Eugen Stan wrote:
Hello Eric,
I don't have time to look over it now. I'm on it over the weekend. The
plugin should work for children pom's if we configure it in the
parent.
Cheers,
On Tue, Jan 8, 2013 at 6:54 PM, Eric Charles <e...@apache.org> wrote:
Yes sure, I had added a comment on the JIRA in that way.
I tough it was solving the following issue, but it doesn't. I will revert.
I see james-server-queue-jms pom which has extra definition
(maven-jar-plugin with goal test-jar, see [3]) but not
james-server-protocols-smtp, resulting in the absence of test-jar for [2]
(well available in [1]).
I would be better to solve this for all module so we don't have to define in
all pom extra configuration for maven-jar-plugin.
Any idea to solve this as the apache parent and my last commit don't give
solution?
Thx, Eric
[1]
https://repository.apache.org/content/groups/snapshots/org/apache/james/james-server-queue-jms/3.0-beta5-SNAPSHOT/
[2]
https://repository.apache.org/content/groups/snapshots/org/apache/james/james-server-protocols-smtp/3.0-beta5-SNAPSHOT/
[3]
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<executions>
<execution>
<goals>
<goal>test-jar</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
On 08/01/2013 16:41, Ioan Eugen Stan wrote:
Hello Eric,
I think most of the plugins are configured in apache pom and we should
avoid duplication as much as possible.
Cheers,
On Tue, Jan 8, 2013 at 4:18 PM, <e...@apache.org> wrote:
Author: eric
Date: Tue Jan 8 14:18:13 2013
New Revision: 1430296
URL: http://svn.apache.org/viewvc?rev=1430296&view=rev
Log:
James parent should enforce the test-jar generation (JAMES-1465)
Modified:
james/project/trunk/pom.xml
Modified: james/project/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/james/project/trunk/pom.xml?rev=1430296&r1=1430295&r2=1430296&view=diff
==============================================================================
--- james/project/trunk/pom.xml (original)
+++ james/project/trunk/pom.xml Tue Jan 8 14:18:13 2013
@@ -646,6 +646,38 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>2.4</version>
+ <executions>
+ <execution>
+ <id>jar</id>
+ <phase>package</phase>
+ <goals>
+ <goal>jar</goal>
+ </goals>
+ <configuration>
+ <archive>
+ <manifest>
+
<addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
+
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
+ </manifest>
+ </archive>
+ </configuration>
+ </execution>
+ <execution>
+ <id>test-jar</id>
+ <phase>package</phase>
+ <goals>
+ <goal>test-jar</goal>
+ </goals>
+ <configuration>
+ <archive>
+ <manifest>
+
<addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
+
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
+ </manifest>
+ </archive>
+ </configuration>
+ </execution>
+ </executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
@@ -740,6 +772,15 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>2.2.1</version>
+ <executions>
+ <execution>
+ <id>attach-sources</id>
+ <goals>
+ <goal>jar</goal>
+ <goal>test-jar</goal>
+ </goals>
+ </execution>
+ </executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
