[ 
https://issues.apache.org/jira/browse/MAILBOX-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13725232#comment-13725232
 ] 

Eric Charles commented on MAILBOX-198:
--------------------------------------

tried to apply MAILBOX-198-2.patch but still falling:

eric@eric:/o/james.svn/mailbox$ patch -p0 --dry-run < MAILBOX-198-2.patch 
patching file 
store/src/main/java/org/apache/james/mailbox/store/search/SimpleMessageSearchIndex.java
Hunk #1 FAILED at 18.
Hunk #2 FAILED at 52.
2 out of 2 hunks FAILED -- saving rejects to file 
store/src/main/java/org/apache/james/mailbox/store/search/SimpleMessageSearchIndex.java.rej
eric@eric:/o/james.svn/mailbox$ 

I see it is created from revision 1508848 and trunk is at revision 1508849,

eric@eric:/o/james.svn/mailbox$ svn up
Updating '.':
At revision 1508849.

                
> Improve SimpleMessageSearchIndex performance
> --------------------------------------------
>
>                 Key: MAILBOX-198
>                 URL: https://issues.apache.org/jira/browse/MAILBOX-198
>             Project: James Mailbox
>          Issue Type: Improvement
>            Reporter: Jan-Philipp Niewerth
>              Labels: PatchAvailable
>         Attachments: MAILBOX-198-2.patch
>
>
> SimpleMessageSearchIndex has O(n^2) performance for searches at the moment. 
> This leads to very bad message check performance for e.g the Android 
> Mailclient on big mailboxes.
> The reason for that is that the current code buffers messages in an ArrayList 
> while performing an contains() check before each add(). A TreeSet is more 
> appropriate here reducing runtime to O(n*log(n)). 
> Furthermore the existing UID range optimization is not effective when other 
> criteria are conjugated with the query.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to