[ 
https://issues.apache.org/jira/browse/MAILBOX-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513038#comment-14513038
 ] 

Eric Charles commented on MAILBOX-223:
--------------------------------------

tried to apply the 2 patches on latest SVN revision:

eric@eric:/s/james/mailbox$ git apply  /d/000
0001-MAILBOX-223-Update-API-so-that-ACL-operation-are-acc.patch   
0002-MAILBOX-223-Remove-MaildirMailbox-use-SimpleMailbox-2.patch  
eric@eric:/s/james/mailbox$ git apply --check 
/d/0001-MAILBOX-223-Update-API-so-that-ACL-operation-are-acc.patch
==> OK

eric@eric:/s/james/mailbox$ git apply --check 
/d/0002-MAILBOX-223-Remove-MaildirMailbox-use-SimpleMailbox-2.patch
error: patch failed: 
maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirStore.java:125
error: 
maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirStore.java: patch 
does not apply
error: patch failed: 
maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMailboxMapper.java:112
error: 
maildir/src/main/java/org/apache/james/mailbox/maildir/mail/MaildirMailboxMapper.java:
 patch does not apply
error: patch failed: 
maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMailbox.java:1
error: 
maildir/src/main/java/org/apache/james/mailbox/maildir/mail/model/MaildirMailbox.java:
 patch does not apply
==> Patch is not applicable - Can you double check please?

> ACL interfaces refactor
> -----------------------
>
>                 Key: MAILBOX-223
>                 URL: https://issues.apache.org/jira/browse/MAILBOX-223
>             Project: James Mailbox
>          Issue Type: Improvement
>            Reporter: Tellier Benoit
>         Attachments: 
> 0001-MAILBOX-223-Update-API-so-that-ACL-operation-are-acc.patch, 
> 0002-MAILBOX-223-Remove-MaildirMailbox-use-SimpleMailbox-.patch
>
>
> ACL management should be delegated to mailbox manager.
> Updating ACL should be done in the MailboxMapper to allow implementation 
> specific operations. We should not overwrite the SimpleMailbox Bean to 
> achieve our goals.
> Currently available implementation should not have changed behavior. Hence 
> Maildir implementation need to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to