Github user chibenwa commented on a diff in the pull request:

    https://github.com/apache/james-project/pull/13#discussion_r43659960
  
    --- Diff: 
mailbox/tool/src/main/java/org/apache/james/mailbox/indexer/registrations/MailboxRegistration.java
 ---
    @@ -0,0 +1,62 @@
    +/****************************************************************
    + * Licensed to the Apache Software Foundation (ASF) under one   *
    + * or more contributor license agreements.  See the NOTICE file *
    + * distributed with this work for additional information        *
    + * regarding copyright ownership.  The ASF licenses this file   *
    + * to you under the Apache License, Version 2.0 (the            *
    + * "License"); you may not use this file except in compliance   *
    + * with the License.  You may obtain a copy of the License at   *
    + *                                                              *
    + *   http://www.apache.org/licenses/LICENSE-2.0                 *
    + *                                                              *
    + * Unless required by applicable law or agreed to in writing,   *
    + * software distributed under the License is distributed on an  *
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY       *
    + * KIND, either express or implied.  See the License for the    *
    + * specific language governing permissions and limitations      *
    + * under the License.                                           *
    + ****************************************************************/
    +
    +package org.apache.james.mailbox.indexer.registrations;
    +
    +import com.google.common.collect.ArrayListMultimap;
    +import com.google.common.collect.ImmutableList;
    +import com.google.common.collect.Multimap;
    +import com.google.common.collect.Multimaps;
    +import org.apache.james.mailbox.MailboxListener;
    +import org.apache.james.mailbox.indexer.events.FlagsMessageEvent;
    +import org.apache.james.mailbox.indexer.events.ImpactingMessageEvent;
    +import org.apache.james.mailbox.indexer.events.MessageDeletedEvent;
    +import org.apache.james.mailbox.model.MailboxPath;
    +import org.apache.james.mailbox.model.UpdatedFlags;
    +
    +import java.util.Collection;
    +
    +public class MailboxRegistration implements MailboxListener {
    +
    +    private final Multimap<Long, ImpactingMessageEvent> 
impactingMessageEvents;
    +    private final MailboxPath mailboxPath;
    +
    +    public MailboxRegistration(MailboxPath mailboxPath) {
    +        this.impactingMessageEvents = 
Multimaps.synchronizedMultimap(ArrayListMultimap.<Long, 
ImpactingMessageEvent>create());
    --- End diff --
    
    From having lock contained in a guava object, obviously. This means only 
one lock can be held by a bunch of code. At most one lock all the time is 
equal, according to me to "no situations where somthing bad can arise".
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to