[ 
https://issues.apache.org/jira/browse/JAMES-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118291#comment-15118291
 ] 

Tellier Benoit commented on JAMES-1670:
---------------------------------------

Ok, it looks like I am the one to blame for  the "folder" init parameter 
disparition. It disepeared during a refactor to make folder variable in 
SieveMailet immutable. I am glad you spotted it.

Concerning the "consume" parameter, I had a look to the code base and couldn't 
stop which commit made it disapear.

We definitly lack tests on mailets. I think we should have at least one test 
per mailet and initParameter to avoid such situation to appear again. We (I, I 
mean) should also work on the review process.

Anyway, if you want any help for the documentation / unit tests for this, just 
ask, I will be happy to help.

> ToRecipientFolder mailet should use init parameters
> ---------------------------------------------------
>
>                 Key: JAMES-1670
>                 URL: https://issues.apache.org/jira/browse/JAMES-1670
>             Project: James Server
>          Issue Type: Bug
>    Affects Versions: Trunk
>            Reporter: Ahmet Kaplan
>            Priority: Minor
>
> ToRecipientFolder mailet has two parameters: folder and consume.
> Previously these parameters processed correctly but while integrating 
> sieverepository, the parameters are disappeared.
> I propose to use folder and consume parameters again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to